Fix SCF loop type inference with bounded widening - #730
Open
nathanieltornow wants to merge 1 commit into
Open
Conversation
Infer loop-carried types to a stable invariant and publish the converged body types. Widen changing literal parameters and bound structural growth, raising an interpreter error if inference cannot establish an invariant. Preserve explicit element types for empty ILists. Cover incorrect map unrolling on growing lists, branch-dependent and dependent loop updates, nested loops, retained precision, repeated inference, and bounded fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #512. Supports #728.
Infer
scf.Forloop-carried types to a stable invariant before publishing body types. Widen changing literal parameters while retaining stable information. Preserves explicit element types for empty ILists.This prevents IList unrolling from using lengths that are valid only during the first iteration. For example:
Before the fix:
After the fix: